[API-NEXT,v3,3/3] api: crypto: deprecate DES algorithm

Message ID 1514422807-6007-4-git-send-email-odpbot@yandex.ru
State New
Headers show
Series
  • api: crypto: deprecate DES algorithm
Related show

Commit Message

Github ODP bot Dec. 28, 2017, 1 a.m.
From: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>


DES is too weak, 56-bit keys, 64-bit blocks. Can be cracked nearly
bare-handed nowadays. Depreate it now, to be dropped in next release.
Note: Tripple-DES (TDES) remains in place.

Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

---
/** Email created from pull request 374 (lumag:no-des)
 ** https://github.com/Linaro/odp/pull/374
 ** Patch: https://github.com/Linaro/odp/pull/374.patch
 ** Base sha: a7b46491ca049998dc38b0a5b29213a407931523
 ** Merge commit sha: ff1bca033a3fe0d12c1309ba04b1f9d97d6e95a5
 **/
 include/odp/api/spec/crypto.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Patch

diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h
index 81fecbc36..92a02d409 100644
--- a/include/odp/api/spec/crypto.h
+++ b/include/odp/api/spec/crypto.h
@@ -71,9 +71,6 @@  typedef enum {
 	/** No cipher algorithm specified */
 	ODP_CIPHER_ALG_NULL,
 
-	/** DES */
-	ODP_CIPHER_ALG_DES,
-
 	/** Triple DES with cipher block chaining */
 	ODP_CIPHER_ALG_3DES_CBC,
 
@@ -95,6 +92,9 @@  typedef enum {
 	/** @deprecated  Use ODP_CIPHER_ALG_AES_GCM instead */
 	ODP_DEPRECATE(ODP_CIPHER_ALG_AES128_GCM),
 
+	/** @deprecated  Do not use DES, 56-bit keys are too weak nowadays */
+	ODP_DEPRECATE(ODP_CIPHER_ALG_DES),
+
 } odp_cipher_alg_t;
 
 /**
@@ -168,9 +168,6 @@  typedef union odp_crypto_cipher_algos_t {
 		/** ODP_CIPHER_ALG_NULL */
 		uint32_t null        : 1;
 
-		/** ODP_CIPHER_ALG_DES */
-		uint32_t des         : 1;
-
 		/** ODP_CIPHER_ALG_3DES_CBC */
 		uint32_t trides_cbc  : 1;
 
@@ -189,6 +186,9 @@  typedef union odp_crypto_cipher_algos_t {
 		/** @deprecated  Use aes_gcm instead */
 		uint32_t ODP_DEPRECATE(aes128_gcm) : 1;
 
+		/** @deprecated  Too weak, do not use */
+		uint32_t ODP_DEPRECATE(des)        : 1;
+
 	} bit;
 
 	/** All bits of the bit field structure