dpdk: don't run the performance tests

Message ID 1446836383-30924-1-git-send-email-zoltan.kiss@linaro.org
State New
Headers show

Commit Message

Zoltan Kiss Nov. 6, 2015, 6:59 p.m.
Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org>
---
 build-dpdk.sh | 2 ++
 1 file changed, 2 insertions(+)

Comments

Mike Holmes Nov. 6, 2015, 7:39 p.m. | #1
When I run in the standard docker container
https://hub.docker.com/r/roxell/check-odp-ubuntu/

I get the following, I assume the build-dpdk.sh or docker image needs to
configure the environment differently since that container defaults the
user to being root already ?

...
....
make[4]: Entering directory
'/root/check-odp/build/odp/testdir/platform/linux-dpdk/test'
FAIL: pktio/pktio_run
../../../../platform/linux-dpdk/test/wrapper-script.sh: line 19: sudo:
command not found
Mounting hugetlbfs
../../../../platform/linux-dpdk/test/wrapper-script.sh: line 26: sudo:
command not found
../../../../platform/linux-dpdk/test/wrapper-script.sh: line 27: sudo:
command not found
Total number: 0
Free pages: 0
running ./../../../test/validation/buffer/buffer_main!
../../../../platform/linux-dpdk/test/wrapper-script.sh: line 31: sudo:
command not found
FAIL: ../../../test/validation/buffer/buffer_main
../../../../platform/linux-dpdk/test/wrapper-script.sh: line 19: sudo:
command not found
Mounting hugetlbfs




On 6 November 2015 at 13:59, Zoltan Kiss <zoltan.kiss@linaro.org> wrote:

> Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org>


---
>  build-dpdk.sh | 2 ++

>  1 file changed, 2 insertions(+)

>

> diff --git a/build-dpdk.sh b/build-dpdk.sh

> index 072efee..e1f9dc4 100755

> --- a/build-dpdk.sh

> +++ b/build-dpdk.sh

> @@ -3,6 +3,8 @@ set -e

>

>  export PLATFORM=${PLATFORM:-linux-dpdk}

>  export ROOT_DIR=$(readlink -f $(dirname $0))

> +# don't do performance tests, they are not working at the moment

> +export PERF_TEST=0

>  source ${ROOT_DIR}/helper/generic

>  export ODP_BUILDDIR="${ODP_BUILDDIR:-${BUILDDIR}/odp-dpdk}"

>

> --

> 1.9.1

>

> _______________________________________________

> lng-odp-dpdk mailing list

> lng-odp-dpdk@lists.linaro.org

> https://lists.linaro.org/mailman/listinfo/lng-odp-dpdk

>




-- 
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
Zoltan Kiss Nov. 7, 2015, 12:01 a.m. | #2
Hm, this patch just disable perf tests through configure. sudo was used 
earlier in the wrapper script, I don't know why it became a problem now.

On 06/11/15 19:39, Mike Holmes wrote:
> When I run in the standard docker container 

> https://hub.docker.com/r/roxell/check-odp-ubuntu/

>

> I get the following, I assume the build-dpdk.sh or docker image needs 

> to configure the environment differently since that container defaults 

> the user to being root already ?

>

> ...

> ....

> make[4]: Entering directory 

> '/root/check-odp/build/odp/testdir/platform/linux-dpdk/test'

> FAIL: pktio/pktio_run

> ../../../../platform/linux-dpdk/test/wrapper-script.sh: line 19: sudo: 

> command not found

> Mounting hugetlbfs

> ../../../../platform/linux-dpdk/test/wrapper-script.sh: line 26: sudo: 

> command not found

> ../../../../platform/linux-dpdk/test/wrapper-script.sh: line 27: sudo: 

> command not found

> Total number: 0

> Free pages: 0

> running ./../../../test/validation/buffer/buffer_main!

> ../../../../platform/linux-dpdk/test/wrapper-script.sh: line 31: sudo: 

> command not found

> FAIL: ../../../test/validation/buffer/buffer_main

> ../../../../platform/linux-dpdk/test/wrapper-script.sh: line 19: sudo: 

> command not found

> Mounting hugetlbfs

>

>

>

>

> On 6 November 2015 at 13:59, Zoltan Kiss <zoltan.kiss@linaro.org 

> <mailto:zoltan.kiss@linaro.org>> wrote:

>

>     Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org

>     <mailto:zoltan.kiss@linaro.org>> 

>

>     ---

>      build-dpdk.sh | 2 ++

>      1 file changed, 2 insertions(+)

>

>     diff --git a/build-dpdk.sh b/build-dpdk.sh

>     index 072efee..e1f9dc4 100755

>     --- a/build-dpdk.sh

>     +++ b/build-dpdk.sh

>     @@ -3,6 +3,8 @@ set -e

>

>      export PLATFORM=${PLATFORM:-linux-dpdk}

>      export ROOT_DIR=$(readlink -f $(dirname $0))

>     +# don't do performance tests, they are not working at the moment

>     +export PERF_TEST=0

>      source ${ROOT_DIR}/helper/generic

>      export ODP_BUILDDIR="${ODP_BUILDDIR:-${BUILDDIR}/odp-dpdk}"

>

>     --

>     1.9.1

>

>     _______________________________________________

>     lng-odp-dpdk mailing list

>     lng-odp-dpdk@lists.linaro.org <mailto:lng-odp-dpdk@lists.linaro.org>

>     https://lists.linaro.org/mailman/listinfo/lng-odp-dpdk

>

>

>

>

> -- 

> Mike Holmes

> Technical Manager - Linaro Networking Group

> Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs

>
Anders Roxell Nov. 7, 2015, 12:59 a.m. | #3
On 7 November 2015 at 01:01, Zoltan Kiss <zoltan.kiss@linaro.org> wrote:
> Hm, this patch just disable perf tests through configure. sudo was used
> earlier in the wrapper script, I don't know why it became a problem now.

You are right, thats due to a miss in that docker image!
I will update the image.

Cheers,
Anders

>
>
> On 06/11/15 19:39, Mike Holmes wrote:
>
> When I run in the standard docker container
> https://hub.docker.com/r/roxell/check-odp-ubuntu/
>
> I get the following, I assume the build-dpdk.sh or docker image needs to
> configure the environment differently since that container defaults the user
> to being root already ?
>
> ...
> ....
> make[4]: Entering directory
> '/root/check-odp/build/odp/testdir/platform/linux-dpdk/test'
> FAIL: pktio/pktio_run
> ../../../../platform/linux-dpdk/test/wrapper-script.sh: line 19: sudo:
> command not found
> Mounting hugetlbfs
> ../../../../platform/linux-dpdk/test/wrapper-script.sh: line 26: sudo:
> command not found
> ../../../../platform/linux-dpdk/test/wrapper-script.sh: line 27: sudo:
> command not found
> Total number: 0
> Free pages: 0
> running ./../../../test/validation/buffer/buffer_main!
> ../../../../platform/linux-dpdk/test/wrapper-script.sh: line 31: sudo:
> command not found
> FAIL: ../../../test/validation/buffer/buffer_main
> ../../../../platform/linux-dpdk/test/wrapper-script.sh: line 19: sudo:
> command not found
> Mounting hugetlbfs
>
>
>
>
> On 6 November 2015 at 13:59, Zoltan Kiss <zoltan.kiss@linaro.org> wrote:
>>
>> Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org>
>>
>> ---
>>  build-dpdk.sh | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/build-dpdk.sh b/build-dpdk.sh
>> index 072efee..e1f9dc4 100755
>> --- a/build-dpdk.sh
>> +++ b/build-dpdk.sh
>> @@ -3,6 +3,8 @@ set -e
>>
>>  export PLATFORM=${PLATFORM:-linux-dpdk}
>>  export ROOT_DIR=$(readlink -f $(dirname $0))
>> +# don't do performance tests, they are not working at the moment
>> +export PERF_TEST=0
>>  source ${ROOT_DIR}/helper/generic
>>  export ODP_BUILDDIR="${ODP_BUILDDIR:-${BUILDDIR}/odp-dpdk}"
>>
>> --
>> 1.9.1
>>
>> _______________________________________________
>> lng-odp-dpdk mailing list
>> lng-odp-dpdk@lists.linaro.org
>> https://lists.linaro.org/mailman/listinfo/lng-odp-dpdk
>
>
>
>
> --
> Mike Holmes
> Technical Manager - Linaro Networking Group
> Linaro.org │ Open source software for ARM SoCs
>
>
>
> _______________________________________________
> lng-odp-dpdk mailing list
> lng-odp-dpdk@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp-dpdk
>
Anders Roxell Nov. 10, 2015, 9:12 p.m. | #4
On 2015-11-06 18:59, Zoltan Kiss wrote:
> Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org>
> ---
>  build-dpdk.sh | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/build-dpdk.sh b/build-dpdk.sh
> index 072efee..e1f9dc4 100755
> --- a/build-dpdk.sh
> +++ b/build-dpdk.sh
> @@ -3,6 +3,8 @@ set -e
>  
>  export PLATFORM=${PLATFORM:-linux-dpdk}
>  export ROOT_DIR=$(readlink -f $(dirname $0))
> +# don't do performance tests, they are not working at the moment
> +export PERF_TEST=0
>  source ${ROOT_DIR}/helper/generic
>  export ODP_BUILDDIR="${ODP_BUILDDIR:-${BUILDDIR}/odp-dpdk}"
>  
> -- 
> 1.9.1
> 

Applied.

Thanks,
Anders

Patch hide | download patch | download mbox

diff --git a/build-dpdk.sh b/build-dpdk.sh
index 072efee..e1f9dc4 100755
--- a/build-dpdk.sh
+++ b/build-dpdk.sh
@@ -3,6 +3,8 @@  set -e
 
 export PLATFORM=${PLATFORM:-linux-dpdk}
 export ROOT_DIR=$(readlink -f $(dirname $0))
+# don't do performance tests, they are not working at the moment
+export PERF_TEST=0
 source ${ROOT_DIR}/helper/generic
 export ODP_BUILDDIR="${ODP_BUILDDIR:-${BUILDDIR}/odp-dpdk}"