[PATCHv2] platform/linux-dpdk: enable schedule strict priority

Message ID 1474929775-19438-1-git-send-email-balakrishna.garapati@linaro.org
State New
Headers show

Commit Message

Balakrishna Garapati Sept. 26, 2016, 10:42 p.m.
Signed-off-by: Balakrishna Garapati <balakrishna.garapati@linaro.org>
---
 since v1: Corrected the path to odp_schedule.m4

 platform/linux-dpdk/m4/configure.m4    | 1 +
 platform/linux-dpdk/m4/odp_schedule.m4 | 1 +
 2 files changed, 2 insertions(+)
 create mode 120000 platform/linux-dpdk/m4/odp_schedule.m4

--
1.9.1

Comments

Zoltan Kiss Sept. 27, 2016, 10:05 a.m. | #1
On 27/09/16 00:42, Balakrishna Garapati wrote:
> Signed-off-by: Balakrishna Garapati <balakrishna.garapati@linaro.org>
> ---
>   since v1: Corrected the path to odp_schedule.m4
>
>   platform/linux-dpdk/m4/configure.m4    | 1 +
>   platform/linux-dpdk/m4/odp_schedule.m4 | 1 +
>   2 files changed, 2 insertions(+)
>   create mode 120000 platform/linux-dpdk/m4/odp_schedule.m4
>
> diff --git a/platform/linux-dpdk/m4/configure.m4 b/platform/linux-dpdk/m4/configure.m4
> index 730b6e8..aeaebcd 100644
> --- a/platform/linux-dpdk/m4/configure.m4
> +++ b/platform/linux-dpdk/m4/configure.m4
> @@ -33,6 +33,7 @@ AC_LINK_IFELSE(
>   AM_CONDITIONAL([HAVE_PCAP], [false])
>   m4_include([platform/linux-dpdk/m4/odp_pthread.m4])
>   m4_include([platform/linux-dpdk/m4/odp_openssl.m4])
> +m4_include([platform/linux-dpdk/m4/odp_schedule.m4])

Why don't you include this file from linux-generic dir? Or is there a 
plan to change the copy in linux-dpdk/m4 to something else than a simple 
link?
>
>   #
>   # Check that SDK_INSTALL_PATH provided to right dpdk version
> diff --git a/platform/linux-dpdk/m4/odp_schedule.m4 b/platform/linux-dpdk/m4/odp_schedule.m4
> new file mode 120000
> index 0000000..7b211bd
> --- /dev/null
> +++ b/platform/linux-dpdk/m4/odp_schedule.m4
> @@ -0,0 +1 @@
> +../../linux-generic/m4/odp_schedule.m4
> \ No newline at end of file
> --
> 1.9.1
>
> _______________________________________________
> lng-odp-dpdk mailing list
> lng-odp-dpdk@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp-dpdk
Balakrishna Garapati Sept. 27, 2016, 5:28 p.m. | #2
On 27 September 2016 at 12:05, Zoltan Kiss <zoltan.kiss@schaman.hu> wrote:

> On 27/09/16 00:42, Balakrishna Garapati wrote:
>
>> Signed-off-by: Balakrishna Garapati <balakrishna.garapati@linaro.org>
>> ---
>>   since v1: Corrected the path to odp_schedule.m4
>>
>>   platform/linux-dpdk/m4/configure.m4    | 1 +
>>   platform/linux-dpdk/m4/odp_schedule.m4 | 1 +
>>   2 files changed, 2 insertions(+)
>>   create mode 120000 platform/linux-dpdk/m4/odp_schedule.m4
>>
>> diff --git a/platform/linux-dpdk/m4/configure.m4
>> b/platform/linux-dpdk/m4/configure.m4
>> index 730b6e8..aeaebcd 100644
>> --- a/platform/linux-dpdk/m4/configure.m4
>> +++ b/platform/linux-dpdk/m4/configure.m4
>> @@ -33,6 +33,7 @@ AC_LINK_IFELSE(
>>   AM_CONDITIONAL([HAVE_PCAP], [false])
>>   m4_include([platform/linux-dpdk/m4/odp_pthread.m4])
>>   m4_include([platform/linux-dpdk/m4/odp_openssl.m4])
>> +m4_include([platform/linux-dpdk/m4/odp_schedule.m4])
>>
>
> Why don't you include this file from linux-generic dir? Or is there a plan
> to change the copy in linux-dpdk/m4 to something else than a simple link?

I just thought of making it look similar to other m4_includes style.

/Krishna

>
>>   #
>>   # Check that SDK_INSTALL_PATH provided to right dpdk version
>> diff --git a/platform/linux-dpdk/m4/odp_schedule.m4
>> b/platform/linux-dpdk/m4/odp_schedule.m4
>> new file mode 120000
>> index 0000000..7b211bd
>> --- /dev/null
>> +++ b/platform/linux-dpdk/m4/odp_schedule.m4
>> @@ -0,0 +1 @@
>> +../../linux-generic/m4/odp_schedule.m4
>> \ No newline at end of file
>> --
>> 1.9.1
>>
>> _______________________________________________
>> lng-odp-dpdk mailing list
>> lng-odp-dpdk@lists.linaro.org
>> https://lists.linaro.org/mailman/listinfo/lng-odp-dpdk
>>
>
>
Zoltan Kiss Sept. 30, 2016, 10:02 p.m. | #3
On 27/09/16 19:28, Krishna Garapati wrote:
>
>
> On 27 September 2016 at 12:05, Zoltan Kiss <zoltan.kiss@schaman.hu 
> <mailto:zoltan.kiss@schaman.hu>> wrote:
>
>     On 27/09/16 00:42, Balakrishna Garapati wrote:
>
>         Signed-off-by: Balakrishna Garapati
>         <balakrishna.garapati@linaro.org
>         <mailto:balakrishna.garapati@linaro.org>>
>         ---
>           since v1: Corrected the path to odp_schedule.m4
>
>           platform/linux-dpdk/m4/configure.m4    | 1 +
>           platform/linux-dpdk/m4/odp_schedule.m4 | 1 +
>           2 files changed, 2 insertions(+)
>           create mode 120000 platform/linux-dpdk/m4/odp_schedule.m4
>
>         diff --git a/platform/linux-dpdk/m4/configure.m4
>         b/platform/linux-dpdk/m4/configure.m4
>         index 730b6e8..aeaebcd 100644
>         --- a/platform/linux-dpdk/m4/configure.m4
>         +++ b/platform/linux-dpdk/m4/configure.m4
>         @@ -33,6 +33,7 @@ AC_LINK_IFELSE(
>           AM_CONDITIONAL([HAVE_PCAP], [false])
>           m4_include([platform/linux-dpdk/m4/odp_pthread.m4])
>           m4_include([platform/linux-dpdk/m4/odp_openssl.m4])
>         +m4_include([platform/linux-dpdk/m4/odp_schedule.m4])
>
>
>     Why don't you include this file from linux-generic dir? Or is
>     there a plan to change the copy in linux-dpdk/m4 to something else
>     than a simple link? 
>
> I just thought of making it look similar to other m4_includes style.

Right, now I vaguely remember there was a reason while those files are 
symlinks instead of having a direct reference to the original from 
configure.m4, but I don't remember what was the problem with that 
version. You might want to give it a quick try to build that way, otherwise:

Reviewed-by: Zoltan Kiss <zoltan.kiss@schaman.hu>

>
> /Krishna
>
>
>           #
>           # Check that SDK_INSTALL_PATH provided to right dpdk version
>         diff --git a/platform/linux-dpdk/m4/odp_schedule.m4
>         b/platform/linux-dpdk/m4/odp_schedule.m4
>         new file mode 120000
>         index 0000000..7b211bd
>         --- /dev/null
>         +++ b/platform/linux-dpdk/m4/odp_schedule.m4
>         @@ -0,0 +1 @@
>         +../../linux-generic/m4/odp_schedule.m4
>         \ No newline at end of file
>         --
>         1.9.1
>
>         _______________________________________________
>         lng-odp-dpdk mailing list
>         lng-odp-dpdk@lists.linaro.org
>         <mailto:lng-odp-dpdk@lists.linaro.org>
>         https://lists.linaro.org/mailman/listinfo/lng-odp-dpdk
>         <https://lists.linaro.org/mailman/listinfo/lng-odp-dpdk>
>
>
>

Patch hide | download patch | download mbox

diff --git a/platform/linux-dpdk/m4/configure.m4 b/platform/linux-dpdk/m4/configure.m4
index 730b6e8..aeaebcd 100644
--- a/platform/linux-dpdk/m4/configure.m4
+++ b/platform/linux-dpdk/m4/configure.m4
@@ -33,6 +33,7 @@  AC_LINK_IFELSE(
 AM_CONDITIONAL([HAVE_PCAP], [false])
 m4_include([platform/linux-dpdk/m4/odp_pthread.m4])
 m4_include([platform/linux-dpdk/m4/odp_openssl.m4])
+m4_include([platform/linux-dpdk/m4/odp_schedule.m4])

 #
 # Check that SDK_INSTALL_PATH provided to right dpdk version
diff --git a/platform/linux-dpdk/m4/odp_schedule.m4 b/platform/linux-dpdk/m4/odp_schedule.m4
new file mode 120000
index 0000000..7b211bd
--- /dev/null
+++ b/platform/linux-dpdk/m4/odp_schedule.m4
@@ -0,0 +1 @@ 
+../../linux-generic/m4/odp_schedule.m4
\ No newline at end of file