[API-NEXT,v2,2/2] api: ipsec: add max number of cos capability

Message ID 20170602093820.23064-3-petri.savolainen@linaro.org
State New
Headers show
Series
  • IPsec API update
Related show

Commit Message

Petri Savolainen June 2, 2017, 9:38 a.m.
Added capability for maximum number of different CoS in
CLS pipelining.

Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org>

---
 include/odp/api/spec/ipsec.h | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

-- 
2.11.0

Comments

Nikhil Agarwal June 6, 2017, 9:25 a.m. | #1
-----Original Message-----
From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of Petri Savolainen

Sent: Friday, June 02, 2017 3:08 PM
To: lng-odp@lists.linaro.org
Subject: [lng-odp] [API-NEXT PATCH v2 2/2] api: ipsec: add max number of cos capability

Added capability for maximum number of different CoS in CLS pipelining.

Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org>

---
 include/odp/api/spec/ipsec.h | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

 	 *  0: Limit is not supported
@@ -679,7 +685,8 @@ typedef struct odp_ipsec_sa_param_t {
 	 *  classification through this CoS. Other result events are sent to
 	 *  'dest_queue'. This field is considered only when 'pipeline' is
 	 *  ODP_IPSEC_PIPELINE_CLS. The CoS must not be shared between any pktio
-	 *  interface default CoS.
+	 *  interface default CoS. The maximum number of different CoS supported
+	 *  is defined by IPsec capability max_cls_cos.
 	 */
 	odp_cos_t dest_cos;
 
--
2.11.0diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h index 24f9fb18..ed4a470e 100644
--- a/include/odp/api/spec/ipsec.h
+++ b/include/odp/api/spec/ipsec.h
@@ -262,6 +262,12 @@ typedef struct odp_ipsec_capability_t {
 	 */
 	odp_support_t pipeline_cls;
 
+	/** Maximum number of different destination CoSes in classification
+	 *  pipelining. The same CoS may be used for many SAs. This is equal or
+	 *  less than 'max_cos' capability in classifier API.
+	 */
+	uint32_t max_cls_cos;
+
We discussed to add maximum number of IPSEC queues as well.
 	/** Soft expiry limit in seconds support
 	 *

Savolainen, Petri (Nokia - FI/Espoo) June 6, 2017, 10:57 a.m. | #2
> -----Original Message-----

> From: Nikhil Agarwal [mailto:nikhil.agarwal@nxp.com]

> Sent: Tuesday, June 06, 2017 12:26 PM

> To: Petri Savolainen <petri.savolainen@linaro.org>; lng-

> odp@lists.linaro.org

> Subject: RE: [lng-odp] [API-NEXT PATCH v2 2/2] api: ipsec: add max number

> of cos capability

> 

> 

> 

> -----Original Message-----

> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of Petri

> Savolainen

> Sent: Friday, June 02, 2017 3:08 PM

> To: lng-odp@lists.linaro.org

> Subject: [lng-odp] [API-NEXT PATCH v2 2/2] api: ipsec: add max number of

> cos capability

> 

> Added capability for maximum number of different CoS in CLS pipelining.

> 

> Signed-off-by: Petri Savolainen <petri.savolainen@linaro.org>

> ---

>  include/odp/api/spec/ipsec.h | 9 ++++++++-

>  1 file changed, 8 insertions(+), 1 deletion(-)

> 

> diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h

> index 24f9fb18..ed4a470e 100644

> --- a/include/odp/api/spec/ipsec.h

> +++ b/include/odp/api/spec/ipsec.h

> @@ -262,6 +262,12 @@ typedef struct odp_ipsec_capability_t {

>  	 */

>  	odp_support_t pipeline_cls;

> 

> +	/** Maximum number of different destination CoSes in

> classification

> +	 *  pipelining. The same CoS may be used for many SAs. This is

> equal or

> +	 *  less than 'max_cos' capability in classifier API.

> +	 */

> +	uint32_t max_cls_cos;

> +

> We discussed to add maximum number of IPSEC queues as well.



I have it on my todo list. We can add it as another patch. This set was already reviewed but forgotten. So, I'd like to merge this first and continue from there.

-Petri


>  	/** Soft expiry limit in seconds support

>  	 *

>  	 *  0: Limit is not supported

> @@ -679,7 +685,8 @@ typedef struct odp_ipsec_sa_param_t {

>  	 *  classification through this CoS. Other result events are

> sent to

>  	 *  'dest_queue'. This field is considered only when 'pipeline'

> is

>  	 *  ODP_IPSEC_PIPELINE_CLS. The CoS must not be shared between

> any pktio

> -	 *  interface default CoS.

> +	 *  interface default CoS. The maximum number of different CoS

> supported

> +	 *  is defined by IPsec capability max_cls_cos.

>  	 */

>  	odp_cos_t dest_cos;

> 

> --

> 2.11.0

Patch hide | download patch | download mbox

diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h
index 24f9fb18..ed4a470e 100644
--- a/include/odp/api/spec/ipsec.h
+++ b/include/odp/api/spec/ipsec.h
@@ -262,6 +262,12 @@  typedef struct odp_ipsec_capability_t {
 	 */
 	odp_support_t pipeline_cls;
 
+	/** Maximum number of different destination CoSes in classification
+	 *  pipelining. The same CoS may be used for many SAs. This is equal or
+	 *  less than 'max_cos' capability in classifier API.
+	 */
+	uint32_t max_cls_cos;
+
 	/** Soft expiry limit in seconds support
 	 *
 	 *  0: Limit is not supported
@@ -679,7 +685,8 @@  typedef struct odp_ipsec_sa_param_t {
 	 *  classification through this CoS. Other result events are sent to
 	 *  'dest_queue'. This field is considered only when 'pipeline' is
 	 *  ODP_IPSEC_PIPELINE_CLS. The CoS must not be shared between any pktio
-	 *  interface default CoS.
+	 *  interface default CoS. The maximum number of different CoS supported
+	 *  is defined by IPsec capability max_cls_cos.
 	 */
 	odp_cos_t dest_cos;