[v2,2/2] travis: enable samples and tests when make distcheck

Message ID 1497859209-10760-3-git-send-email-odpbot@yandex.ru
State Superseded
Headers show
Series
  • test: traffic_mngr: fix install-check failure
Related show

Commit Message

Github ODP bot June 19, 2017, 8 a.m.
From: Yi He <yi.he@linaro.org>


enable samples and tests when make distcheck to
confirm samples and test programs installation and
distribution builds.

Signed-off-by: Yi He <yi.he@linaro.org>

---
/** Email created from pull request 35 (heyi-linaro:install-check)
 ** https://github.com/Linaro/odp/pull/35
 ** Patch: https://github.com/Linaro/odp/pull/35.patch
 ** Base sha: 4bda102286cf55b0bc93fdf8f8f276d5528fdf14
 ** Merge commit sha: 44aa7de8407d751055353d99ed665dc7733f8dbb
 **/
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maxim Uvarov June 20, 2017, 7:50 p.m. | #1
No, that patch is not correct. Take a look at top level Makefile.am:
AM_DISTCHECK_CONFIGURE_FLAGS = --enable-test-cpp \
                               --enable-test-perf \
                               --enable-test-vald \
                               --with-testdir

parameters to configure are skipped and only that one are used.

Maxim.


On 06/19/17 11:00, Github ODP bot wrote:
> From: Yi He <yi.he@linaro.org>

> 

> enable samples and tests when make distcheck to

> confirm samples and test programs installation and

> distribution builds.

> 

> Signed-off-by: Yi He <yi.he@linaro.org>

> ---

> /** Email created from pull request 35 (heyi-linaro:install-check)

>  ** https://github.com/Linaro/odp/pull/35

>  ** Patch: https://github.com/Linaro/odp/pull/35.patch

>  ** Base sha: 4bda102286cf55b0bc93fdf8f8f276d5528fdf14

>  ** Merge commit sha: 44aa7de8407d751055353d99ed665dc7733f8dbb

>  **/

>  .travis.yml | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/.travis.yml b/.travis.yml

> index 50b3b9c2..8407906e 100644

> --- a/.travis.yml

> +++ b/.travis.yml

> @@ -136,7 +136,7 @@ jobs:

>                    compiler: gcc

>                    script:

>                            - ./bootstrap

> -                          - ./configure

> +                          - ./configure --prefix=$HOME/odp-install --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf --enable-test-perf-proc --enable-test-example --with-dpdk-path=`pwd`/dpdk/${TARGET} --with-netmap-path=`pwd`/netmap

>                            - sudo LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" make distcheck

>                  - stage: test

>                    env: TEST=doxygen

>
Maxim Uvarov June 20, 2017, 7:53 p.m. | #2
Yi, how about something like:

                   compiler: gcc
                   script:


On 06/19/17 11:00, Github ODP bot wrote:
> From: Yi He <yi.he@linaro.org>

> 

> enable samples and tests when make distcheck to

> confirm samples and test programs installation and

> distribution builds.

> 

> Signed-off-by: Yi He <yi.he@linaro.org>

> ---

> /** Email created from pull request 35 (heyi-linaro:install-check)

>  ** https://github.com/Linaro/odp/pull/35

>  ** Patch: https://github.com/Linaro/odp/pull/35.patch

>  ** Base sha: 4bda102286cf55b0bc93fdf8f8f276d5528fdf14

>  ** Merge commit sha: 44aa7de8407d751055353d99ed665dc7733f8dbb

>  **/

>  .travis.yml | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/.travis.yml b/.travis.yml

> index 50b3b9c2..8407906e 100644

> --- a/.travis.yml

> +++ b/.travis.yml

> @@ -136,7 +136,7 @@ jobs:

>                    compiler: gcc

>                    script:

>                            - ./bootstrap

> -                          - ./configure

> +                          - ./configure --prefix=$HOME/odp-install --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf --enable-test-perf-proc --enable-test-example --with-dpdk-path=`pwd`/dpdk/${TARGET} --with-netmap-path=`pwd`/netmap

>                            - sudo LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" make distcheck

>                  - stage: test

>                    env: TEST=doxygen

>diff --git a/.travis.yml b/.travis.yml

index 50b3b9c2..3d641209 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -139,6 +139,13 @@ jobs:
                           - ./configure
                           - sudo
LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" make distcheck
                 - stage: test
+                  env: TEST=install-check
+                  compiler: gcc
+                  script:
+                          - ./bootstrap
+                          - ./configure
+                          - sudo
LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" make install-check
+                - stage: test
                   env: TEST=doxygen

Dmitry Eremin-Solenikov June 20, 2017, 9:44 p.m. | #3
On 20.06.2017 22:53, Maxim Uvarov wrote:
> Yi, how about something like:

> 

> diff --git a/.travis.yml b/.travis.yml

> index 50b3b9c2..3d641209 100644

> --- a/.travis.yml

> +++ b/.travis.yml

> @@ -139,6 +139,13 @@ jobs:

>                            - ./configure

>                            - sudo

> LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" make distcheck

>                  - stage: test

> +                  env: TEST=install-check

> +                  compiler: gcc

> +                  script:

> +                          - ./bootstrap

> +                          - ./configure

> +                          - sudo

> LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" make install-check


1) There is no install-check target, only installcheck (at least with
Automake 1.15)

2) Would it make sense to run make installcheck with all possible
options enabled?

> +                - stage: test

>                    env: TEST=doxygen

>                    compiler: gcc

>                    script:

> 

> 

> On 06/19/17 11:00, Github ODP bot wrote:

>> From: Yi He <yi.he@linaro.org>

>>

>> enable samples and tests when make distcheck to

>> confirm samples and test programs installation and

>> distribution builds.

>>

>> Signed-off-by: Yi He <yi.he@linaro.org>

>> ---

>> /** Email created from pull request 35 (heyi-linaro:install-check)

>>  ** https://github.com/Linaro/odp/pull/35

>>  ** Patch: https://github.com/Linaro/odp/pull/35.patch

>>  ** Base sha: 4bda102286cf55b0bc93fdf8f8f276d5528fdf14

>>  ** Merge commit sha: 44aa7de8407d751055353d99ed665dc7733f8dbb

>>  **/

>>  .travis.yml | 2 +-

>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/.travis.yml b/.travis.yml

>> index 50b3b9c2..8407906e 100644

>> --- a/.travis.yml

>> +++ b/.travis.yml

>> @@ -136,7 +136,7 @@ jobs:

>>                    compiler: gcc

>>                    script:

>>                            - ./bootstrap

>> -                          - ./configure

>> +                          - ./configure --prefix=$HOME/odp-install --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf --enable-test-perf-proc --enable-test-example --with-dpdk-path=`pwd`/dpdk/${TARGET} --with-netmap-path=`pwd`/netmap

>>                            - sudo LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" make distcheck

>>                  - stage: test

>>                    env: TEST=doxygen

>>

> 



-- 
With best wishes
Dmitry
Yi He June 21, 2017, 1:04 a.m. | #4
Thanks Maxim and Dmitry

Yes, these patches actually fix problems in installcheck, I'll add a
.travis installcheck target as Maxim suggested, run local tests and then
update the PR.

2) Would it make sense to run make installcheck with all possible
options enabled?

[]: Found that --with-dpdk-path=`pwd`/dpdk/${TARGET}
--with-netmap-path=`pwd`/netmap introduces further failures in
installcheck, if needed I'll add the patches in this PR.

Best Regards, Yi


On 21 June 2017 at 05:44, Dmitry Eremin-Solenikov <
dmitry.ereminsolenikov@linaro.org> wrote:

> On 20.06.2017 22:53, Maxim Uvarov wrote:

> > Yi, how about something like:

> >

> > diff --git a/.travis.yml b/.travis.yml

> > index 50b3b9c2..3d641209 100644

> > --- a/.travis.yml

> > +++ b/.travis.yml

> > @@ -139,6 +139,13 @@ jobs:

> >                            - ./configure

> >                            - sudo

> > LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" make distcheck

> >                  - stage: test

> > +                  env: TEST=install-check

> > +                  compiler: gcc

> > +                  script:

> > +                          - ./bootstrap

> > +                          - ./configure

> > +                          - sudo

> > LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" make install-check

>

> 1) There is no install-check target, only installcheck (at least with

> Automake 1.15)

>

> 2) Would it make sense to run make installcheck with all possible

> options enabled?

>

> > +                - stage: test

> >                    env: TEST=doxygen

> >                    compiler: gcc

> >                    script:

> >

> >

> > On 06/19/17 11:00, Github ODP bot wrote:

> >> From: Yi He <yi.he@linaro.org>

> >>

> >> enable samples and tests when make distcheck to

> >> confirm samples and test programs installation and

> >> distribution builds.

> >>

> >> Signed-off-by: Yi He <yi.he@linaro.org>

> >> ---

> >> /** Email created from pull request 35 (heyi-linaro:install-check)

> >>  ** https://github.com/Linaro/odp/pull/35

> >>  ** Patch: https://github.com/Linaro/odp/pull/35.patch

> >>  ** Base sha: 4bda102286cf55b0bc93fdf8f8f276d5528fdf14

> >>  ** Merge commit sha: 44aa7de8407d751055353d99ed665dc7733f8dbb

> >>  **/

> >>  .travis.yml | 2 +-

> >>  1 file changed, 1 insertion(+), 1 deletion(-)

> >>

> >> diff --git a/.travis.yml b/.travis.yml

> >> index 50b3b9c2..8407906e 100644

> >> --- a/.travis.yml

> >> +++ b/.travis.yml

> >> @@ -136,7 +136,7 @@ jobs:

> >>                    compiler: gcc

> >>                    script:

> >>                            - ./bootstrap

> >> -                          - ./configure

> >> +                          - ./configure --prefix=$HOME/odp-install

> --enable-test-cpp --enable-test-vald --enable-test-helper

> --enable-test-perf --enable-test-perf-proc --enable-test-example

> --with-dpdk-path=`pwd`/dpdk/${TARGET} --with-netmap-path=`pwd`/netmap

> >>                            - sudo LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH"

> make distcheck

> >>                  - stage: test

> >>                    env: TEST=doxygen

> >>

> >

>

>

> --

> With best wishes

> Dmitry

>

Patch hide | download patch | download mbox

diff --git a/.travis.yml b/.travis.yml
index 50b3b9c2..8407906e 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -136,7 +136,7 @@  jobs:
                   compiler: gcc
                   script:
                           - ./bootstrap
-                          - ./configure
+                          - ./configure --prefix=$HOME/odp-install --enable-test-cpp --enable-test-vald --enable-test-helper --enable-test-perf --enable-test-perf-proc --enable-test-example --with-dpdk-path=`pwd`/dpdk/${TARGET} --with-netmap-path=`pwd`/netmap
                           - sudo LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" make distcheck
                 - stage: test
                   env: TEST=doxygen